[CRIU] Re: [PATCH 3/4] inotify: Add checkpoint/restore

Cyrill Gorcunov gorcunov at openvz.org
Wed Apr 11 12:15:40 EDT 2012


On Wed, Apr 11, 2012 at 08:11:48PM +0400, Cyrill Gorcunov wrote:
...
> +int dump_one_inotify(int lfd, u32 id, const struct fd_parms *p)
> +{
> +	struct inotify_file_entry ie;
> +	struct inotify_user_mark m;
> +	struct inotify_mark_req r;
> +	int image_fd;
> +	int ret = -1;
> +	int flags;
> +
> +	image_fd = fdset_fd(glob_fdset, CR_FD_INOTIFY);
> +	flags = fcntl(lfd, F_GETFL);
> +

This call is redundant, the flags can be fetched from fd_parms,
so this nit can be fixed on top if anything else suits you.

	Cyrill


More information about the CRIU mailing list