[CRIU] Re: [PATCH 4/4] inotify: Add checkpoint/restore

Cyrill Gorcunov gorcunov at openvz.org
Tue Apr 10 10:09:39 EDT 2012


On Tue, Apr 10, 2012 at 05:59:26PM +0400, Pavel Emelyanov wrote:
> >>
> >>> +	attempt = 10, wd = 1;
> >>
> >> This means that you only can restore wd-s less than 10 (or 11, I don't try hard
> >> on corner case). This is wrong.
> > 
> > No, attempt is simply a counter. I can't restore if a gap between the
> > wd we need and kernel allocate is greater than 10. I try 10 times
> > and if no success -- just break, simply to not spin here too long.
> 
> OK consider the 1st wd is 20, will you restore this one?

Nope, your truth. I'll add the heuristics to find out minimal
attempts needed to cover such cases. Meanwhile I'm about to
switch to fowners and address your comments on those series.

	Cyrill


More information about the CRIU mailing list