[CRIU] Re: [PATCH] make: Fix dependency generation

[Kinsbursky Stanislav]

06.04.2012 21:31, Pavel Emelyanov пишет:
> On 04/05/2012 06:36 PM, Kinsbursky Stanislav wrote:
>> 05.04.2012 18:19, Cyrill Gorcunov пишет:
>>> Yes, it requires deps and actually deps are generated
>>>
>>> [cyrill at moon crtools]$ touch include/parasite.h
>>> [cyrill at moon crtools]$ make V=1 parasite.o
>>> gcc -c -I./include -O0 -ggdb3 -Werror -Wall -Wno-unused -DCONFIG_X86_64 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -fpic parasite.c -o parasite.o
>>> ld -T parasite.lds.S parasite.o parasite-util-net.o -o parasite.bin
>>> sh gen-offsets.sh parasite>   parasite-blob.h || rm -f parasite-blob.h
>>> sync
>>> gcc -M -MT cr-restore.o -I./include -O0 -ggdb3 -Werror -Wall -Wno-unused -DCONFIG_X86_64 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE cr-restore.c -o cr-restore.d
>>> gcc -M -MT parasite-syscall.o -I./include -O0 -ggdb3 -Werror -Wall -Wno-unused -DCONFIG_X86_64 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE parasite-syscall.c -o parasite-syscall.d
>>> make: `parasite.o' is up to date.
>>>
>>> so as you see parasite.o is recompiled. It seems for cleaner scheme the parasite
>>> and restored should be built via separate Makefile. I'll think about it.
>>> Meanwhile I think the patch is worth to have to eliminate problem with
>>> deps generation on clean target. What do you think?
>> Agreed. Patch is good (except these circular dependences). But this problem
>> can't be fixed easily and actually is another task.
>>
> So, where in this thread the proper patch sits?

There is only one patch in this thread...

-- 
Best regards,
Stanislav Kinsbursky