[CRIU] Re: [PATCH]

[Kinsbursky Stanislav]

05.04.2012 17:34, Cyrill Gorcunov пишет:
> On Thu, Apr 05, 2012 at 05:27:03PM +0400, Cyrill Gorcunov wrote:
>> On Thu, Apr 05, 2012 at 05:21:29PM +0400, Kinsbursky Stanislav wrote:
>>>> No, it didn't (it should actually :). There were a typo in
>>>> commit, the variable should be referenced as $() clause.
>>> Which variable?
>>> Here is the patch:
>>>
>>> commit af76a228edbbfffa231f9594f2152137a03df1a2
>>>
>>> <snip>
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 854dd65..af96112 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -182,4 +182,9 @@ cscope:
>>>          $(Q) $(CSCOPE) -bkqu
>>>   .PHONY: cscope
>>>
>>> +no-blob-targets := tags clean cscope
>>> +
>>> +ifeq ($(filter-out no-blob-targets, $(MAKECMDGOALS)),)
>>>   -include $(DEPS)
>>> +endif
>>> +
>>>
>> no-blob-targets, it should be ref'ed as $(no-blob-targets)
>>
>>>> And the second, it didn't take into account empty make goal.
>>> No, it did.
>>> IOW, deps were built for any target except "tags", "clean" and "cscope".
>> also docs, help
>>
>>> BTW, doesn't it is easier to use short list of targets, which
>>> doesn't require deps, instead of the long list, which does?
>> It depends on which goal appear here in future. I think the last
>> form (which will be after the patch applied) is better, we explicitly
>> point when deps are needed.
>>
> Another problem which is not handled by anything we have before in Makefile
> is deps generation for %.o goals. Example
>
> [cyrill at moon crtools]$ make
>    CC       parasite.o
> 	...
>    LINK     crtools
> [cyrill at moon crtools]$ touch include/parasite.h
> [cyrill at moon crtools]$ make parasite.o
> make: `parasite.o' is up to date.
>

This sound really strange. It work after my commit I mentioned.
But there were some more on top of it. So, who knows.
Anyway, my patch has a flaw in case of building two or more targets, when one or 
more requires deps, and others - not.

> After my last patch applied
>
> [cyrill at moon crtools]$ touch include/parasite.h
> [cyrill at moon crtools]$ make parasite.o
>    CC       parasite.o
>    GEN      parasite.bin
>    GEN      parasite-blob.h
> make: `parasite.o' is up to date.
> [cyrill at moon crtools]$

Does parasite.o requires deps?
If yes, why it wasn't rebuilt?
I no, why does parasite-blob.h was rebuilt?

-- 
Best regards,
Stanislav Kinsbursky