[CRIU] Re: [PATCH]

[Cyrill Gorcunov]

On Thu, Apr 05, 2012 at 05:21:29PM +0400, Kinsbursky Stanislav wrote:
> >No, it didn't (it should actually :). There were a typo in
> >commit, the variable should be referenced as $() clause.
> 
> Which variable?
> Here is the patch:
> 
> commit af76a228edbbfffa231f9594f2152137a03df1a2
> 
> <snip>
> 
> diff --git a/Makefile b/Makefile
> index 854dd65..af96112 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -182,4 +182,9 @@ cscope:
>         $(Q) $(CSCOPE) -bkqu
>  .PHONY: cscope
> 
> +no-blob-targets := tags clean cscope
> +
> +ifeq ($(filter-out no-blob-targets, $(MAKECMDGOALS)),)
>  -include $(DEPS)
> +endif
> +
> 

no-blob-targets, it should be ref'ed as $(no-blob-targets)

> >And the second, it didn't take into account empty make goal.
> 
> No, it did.
> IOW, deps were built for any target except "tags", "clean" and "cscope".

also docs, help

> BTW, doesn't it is easier to use short list of targets, which
> doesn't require deps, instead of the long list, which does?

It depends on which goal appear here in future. I think the last
form (which will be after the patch applied) is better, we explicitly
point when deps are needed.

	Cyrill