[CRIU] Re: [PATCH 09/16] parasite, restore: Add EXPORT_SYMBOL for blob symbol definitions

[Pavel Emelyanov]

On 04/02/2012 11:17 PM, Cyrill Gorcunov wrote:
> On Mon, Apr 02, 2012 at 10:49:10PM +0400, Pavel Emelyanov wrote:
>> On 03/31/2012 02:46 AM, Cyrill Gorcunov wrote:
>>>
>>> Since we only need a few symbols from generated blob files
>>> no need to #define every symbol found. Rather use EXPORT_SYMBOL
>>> helper -- it marks the symbols we need to use and minimizes
>>> the bunch of #define's we generate.
>>>
>>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>> ---
>>
>> Plz, rewrite using objdump -t -j '.export'. I don't like the __export grepping.
>>
> 
> This won't work.

I checked, it works ;)

> Symbol table _still_ in .symtab and names are in .strtab,
> but .export section just guarantee us that marked symbols won't clash with
> anything else (I already met the situation when change_bit helper appeared
> twice in linked object file due to always_inline usage). If some clash happens
> this will trigger bug alarm for us.
> 
> Though if there is strong disagreement with this approach (ie when we parse
> for __export* first and then do parse for appropriate symbol without __export
> prefix) I can think how to make it.
> 
> 	Cyrill
> .
>