[CRIU] Re: [PATCH 1/2] futex: Make raw value being s32

[Cyrill Gorcunov]

On Mon, Apr 02, 2012 at 06:27:31PM +0400, Andrew Wagin wrote:
> 2012/4/2 Cyrill Gorcunov <gorcunov at openvz.org>:
> > On Mon, Apr 02, 2012 at 12:18:40PM +0400, Andrew Vagin wrote:
> >> > -                   ret = sys_futex(&(__f)->raw, FUTEX_WAIT,\
> >> > +                   ret = sys_futex((u32 *)&(__f)->raw, FUTEX_WAIT,\
> >> >                                     tmp, NULL, NULL, 0);    \
> >>
> >
> > I believe we should not. sys_futex is hardcoded by the kernel so
> > better follow kernel's notation.
> 
> It's obvious, that uaddr is a pointer on 4 bytes of memory.

It doesn't matter, this is kernel prototype, period.

> 
> >
> > asmlinkage long sys_futex(u32 __user *uaddr, int op, u32 val,
> >                        struct timespec __user *utime, u32 __user *uaddr2,
> >                        u32 val3);
> 
> We can create own shortcut for that, I don't like type conversation in
> many places.

Sure, I'm fine with that ;)

	Cyrill