[CRIU] Re: [PATCH 1/2] futex: Make raw value being s32

Cyrill Gorcunov gorcunov at openvz.org
Mon Apr 2 04:25:18 EDT 2012


On Mon, Apr 02, 2012 at 12:18:40PM +0400, Andrew Vagin wrote:
> > -			ret = sys_futex(&(__f)->raw, FUTEX_WAIT,\
> > +			ret = sys_futex((u32 *)&(__f)->raw, FUTEX_WAIT,\
> >  					tmp, NULL, NULL, 0);	\
> 

I believe we should not. sys_futex is hardcoded by the kernel so
better follow kernel's notation.

asmlinkage long sys_futex(u32 __user *uaddr, int op, u32 val,
			struct timespec __user *utime, u32 __user *uaddr2,
			u32 val3);

	Cyrill


More information about the CRIU mailing list